Search Issue Tracker

By Design

Votes

1

Found in [Package]

1.5.0-pre.5

Issue ID

LOC-1067

Regression

No

The "rid" value of some entries changes between pulls when pulling from Google sheets

Package: Localization Package

-

Reproduction steps:
1. Open the attached "LocaMergeRidChange" project
2. Open the "Assets/Localization" folder in Windows Explorer
3. In Unity Editor, select "Assets/Localization/Text.asset"
4. Click the "Pull" button in Inspector
5. In Windows Explorer, make a copy of "Assets/Localization/Text Shared Data.asset" and rename the copy to "Assets/Localization/1.txt"
6. Click the "Pull" button in Inspector
7. In Windows Explorer, make a copy of "Assets/Localization/Text Shared Data.asset" and rename the copy to "Assets/Localization/2.txt"
8. Compare "1.txt" and "2.txt"
9. Observe the results

Expected results: The "rid" value of the same entries stays consistent between pulls
Actual results: The "rid" value of some entries is changed

Reproducible in: 1.4.5(2021.3.34f1), 1.5.0-pre.5(2021.3.34f1, 2022.3.17f1, 2023.2.5f1, 2023.3.0b3)

Reproducible on: Windows 11 Pro
Not reproducible on: No other environments tested

  1. Resolution Note:

    The issue is coming from the MaxLengthMetadata inheriting from Comment. This causes the Key Comment Column to treat MaxLengthMetadata as a Comment metadata and will remove it whenever the comment column in the Google sheet is empty. The Max Length Column will then create a new instance to replace the removed one each time. A new instance will require a new rid to be generated. We recommend changing the inheritance to use IMetadata instead of Comment to avoid this issue.

Comments (1)

  1. Peter77

    Jan 23, 2024 17:18

Add comment

Log in to post comment

All about bugs

View bugs we have successfully reproduced, and vote for the bugs you want to see fixed most urgently.