Search Issue Tracker

Fixed

Fixed in 2022.3.5f1, 2023.1.0b14, 2023.2.0a12

Votes

1

Found in

2023.1.0a9

2023.2.0a1

Issue ID

UUM-21184

Regression

Yes

[URP] Can't remove Custom Renderer Feature after it has been deleted or commented out in code

-

Steps to reproduce:

  1. Create a new URP project
  2. Create a Renderer Feature (Assets>Create>Rendering>URP Renderer Feature)
  3. Add this Renderer Feature to any URP Renderer Data asset
  4. Either delete the Renderer Feature or comment its code out in the script file
  5. Inspect the URP Renderer Data asset to find that the Feature is now missing
  6. Try clicking on the three dots on the missing Renderer Feature item

Expected result: a popup with options to Move Up, Move Down and Remove should be displayed

Actual result: an error is thrown and the popup does not open
{quote}NullReferenceException: Object reference not set to an instance of an object
UnityEditor.Rendering.Universal.ScriptableRendererDataEditor.AddShowAdditionalPropertiesMenuItem (UnityEditor.GenericMenu& menu, System.Int32 id) (at Library/PackageCache/com.unity.render-pipelines.universal@15.0.1/Editor/ScriptableRendererDataEditor.cs:234)
UnityEditor.Rendering.Universal.ScriptableRendererDataEditor.OnContextClick (UnityEngine.Vector2 position, System.Int32 id) (at Library/PackageCache/com.unity.render-pipelines.universal@15.0.1/Editor/ScriptableRendererDataEditor.cs:224)
UnityEditor.Rendering.Universal.ScriptableRendererDataEditor+<>c_{_}DisplayClass12_0.<DrawRendererFeature>b{_}0 (UnityEngine.Vector2 pos) (at Library/PackageCache/com.unity.render-pipelines.universal@15.0.1/Editor/ScriptableRendererDataEditor.cs:199)
UnityEditor.Rendering.CoreEditorUtils.CreateContextMenu (UnityEngine.Rect contextMenuRect, System.Action`1[T] contextAction) (at Library/PackageCache/com.unity.render-pipelines.core@15.0.1/Editor/CoreEditorUtils.cs:809)
UnityEditor.Rendering.CoreEditorUtils.ContextMenu (UnityEngine.GUIContent title, System.Action`1[T] contextAction, System.Func`1[TResult] hasMoreOptions, System.Action toggleMoreOptions, System.String documentationURL, UnityEngine.Rect labelRect) (at Library/PackageCache/com.unity.render-pipelines.core@15.0.1/Editor/CoreEditorUtils.cs:739)
UnityEditor.Rendering.CoreEditorUtils.DrawHeaderToggle (UnityEngine.GUIContent title, UnityEditor.SerializedProperty group, UnityEditor.SerializedProperty activeField, System.Action`1[T] contextAction, System.Func`1[TResult] hasMoreOptions, System.Action toggleMoreOptions, System.String documentationURL, System.Action`1[T] customMenuContextAction, System.Boolean isBoxed, System.Boolean isTitleHeader, System.Boolean shouldUpdate) (at Library/PackageCache/com.unity.render-pipelines.core@15.0.1/Editor/CoreEditorUtils.cs:661)
UnityEditor.Rendering.Universal.ScriptableRendererDataEditor.DrawRendererFeature (System.Int32 index, UnityEditor.SerializedProperty& renderFeatureProperty) (at Library/PackageCache/com.unity.render-pipelines.universal@15.0.1/Editor/ScriptableRendererDataEditor.cs:199)
UnityEditor.Rendering.Universal.ScriptableRendererDataEditor.DrawRendererFeatureList () (at Library/PackageCache/com.unity.render-pipelines.universal@15.0.1/Editor/ScriptableRendererDataEditor.cs:87)
UnityEditor.Rendering.Universal.ScriptableRendererDataEditor.OnInspectorGUI () (at Library/PackageCache/com.unity.render-pipelines.universal@15.0.1/Editor/ScriptableRendererDataEditor.cs:68)
UnityEditor.Rendering.Universal.UniversalRendererDataEditor.OnInspectorGUI () (at Library/PackageCache/com.unity.render-pipelines.universal@15.0.1/Editor/UniversalRendererDataEditor.cs:169)
UnityEditor.UIElements.InspectorElement+<>c
{_}DisplayClass71_0.<CreateIMGUIInspectorFromEditor>b{_}_0 () (at /Users/bokken/buildslave/unity/build/Editor/Mono/UIElements/Inspector/InspectorElement.cs:674)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr, Boolean&) (at /Users/bokken/buildslave/unity/build/Modules/IMGUI/GUIUtility.cs:189)
{quote}
Reproducible with: 2023.1.0a9, 2023.1.0a23

Not reproducible with: 2022.2.0a14, 2023.1.0a8

  1. Resolution Note (fix version 2023.2.0a12):

    Fixed in 2023.2.0a12
    Revision: 37c908b5e9a5
    Built: Tue, 18 Apr 2023 12:30:43 GMT

  2. Resolution Note (fix version 2023.1.0b14):

    Fixed in 2023.1.0b14
    Revision: 3321931063a3
    Built: Tue, 18 Apr 2023 12:24:21 GMT

Add comment

Log in to post comment