Search Issue Tracker
Fixed in 2021.2.X
Fixed in 2021.1.X
Votes
0
Found in
2020.1.0a22
Issue ID
1323393
Regression
Yes
Performance regression when baking light probes with a light cookie in the scene
Introduced by https://ono.unity3d.com/unity/unity/pull-request/99050//lighting/plm/lightcookies
OpenCLCommonBuffers::PrepareLightCookiesBuffer is called 500+ times during the bake, because SetSceneStateOnTechnique(this) is called from RadeonRaysBakeLightProbesTechnique::Render()!
This should only be done once, in RadeonRaysBakeLightProbesTechnique::AttachHeavyDataPointers. SetSceneStateOnTechnique isn't tread safe so this can also cause crashes if scene state is changed while baking.
Performance hit was visible in https://confluence.unity3d.com/pages/viewpage.action?spaceKey=teamgi&title=Light+cookie+support+for+PLM but ignored. The more light probe groups and the higher sample counts you have, the worse it gets.
https://ono.unity3d.com/unity/unity/pull-request/99050//lighting/plm/lightcookies landed in trunk at 2020.1.0a22.2693_a851a673d667
All about bugs
View bugs we have successfully reproduced, and vote for the bugs you want to see fixed most urgently.
Latest issues
- Memory leak occurs when focused on Player while using Direct3D12
- var VisionOSEDRHeadromm has a comma instead of a dot when building with Metal Rendering App Mode and local OS localization is set to German
- IAP Catalog remove product “x” and add product “+” buttons are not consistent with other remove and add buttons in the Editor
- Performance issues in Play Mode when quickly hovering the mouse cursor over Hierarchy GameObjects
- Frame Debugger displays incorrect output when FidelityFX Super Resolution or Spatial-Temporal Upscaler is used with Temporal Anti-aliasing or Subpixel Morphological Anti-aliasing
Add comment