Search Issue Tracker
Fixed in 2021.2.X
Fixed in 2021.1.X
Votes
0
Found in
2020.1.0a22
Issue ID
1323393
Regression
Yes
Performance regression when baking light probes with a light cookie in the scene
Introduced by https://ono.unity3d.com/unity/unity/pull-request/99050//lighting/plm/lightcookies
OpenCLCommonBuffers::PrepareLightCookiesBuffer is called 500+ times during the bake, because SetSceneStateOnTechnique(this) is called from RadeonRaysBakeLightProbesTechnique::Render()!
This should only be done once, in RadeonRaysBakeLightProbesTechnique::AttachHeavyDataPointers. SetSceneStateOnTechnique isn't tread safe so this can also cause crashes if scene state is changed while baking.
Performance hit was visible in https://confluence.unity3d.com/pages/viewpage.action?spaceKey=teamgi&title=Light+cookie+support+for+PLM but ignored. The more light probe groups and the higher sample counts you have, the worse it gets.
https://ono.unity3d.com/unity/unity/pull-request/99050//lighting/plm/lightcookies landed in trunk at 2020.1.0a22.2693_a851a673d667
All about bugs
View bugs we have successfully reproduced, and vote for the bugs you want to see fixed most urgently.
Latest issues
- Shader Graph Swizzle Node Input/Output and Mask Update Incorrectly After Undo
- [URP] Crash on GameObject::QueryComponentByType when baking a Reflection Probe in an unsaved/untitled Scene
- No Icons are used for the Entry and Exit States in the Inspector when selected in an Animator Controller
- Crash on PlayerMain(int, char const**) when exiting Standalone Player with a Particle System in the Scene
- No Icon is used for the Runtime Animator Controller Type in a Search Window when assigning an Animator Controller in the Animator Component
Add comment