Search Issue Tracker
Fixed in 2021.3.32f1
Fixed in 2021.3.X, 2022.3.X, 2023.2.X, 2023.3.X, 2023.3.0a10
Votes
2
Found in
2021.3.31f1
2022.3.10f1
2023.2.0b10
2023.3.0a1
Issue ID
UUM-44220
Regression
No
Custom PropertyDrawers are not being released
Add the following script to a project:
{code:java}
using System;
using UnityEditor;
using UnityEngine;
[Serializable]
public class MyClass
{
}
[CustomPropertyDrawer(typeof(MyClass))]
public class MyClassDrawer : PropertyDrawer
{
public override void OnGUI(Rect position, SerializedProperty property, GUIContent label)
{
GUI.Label(position, label);
}
public MyClassDrawer() => Debug.Log("MyClassDrawer");
~MyClassDrawer() => Debug.Log("~MyClassDrawer");
}
public class Test : MonoBehaviour
{
public MyClass myClass = new MyClass();
}
{code}
- Add the Test component to a GameObject
- Select the GameObject, notice the property drawer is created.
- Deselect and reselect. A new drawer is created every time but the finalizer/destructor is never called.
- Enter playmode or change a script. All the finalizers are called.
It seems that something is holding onto the property drawer and preventing them from being garbage collected. This makes it hard to clean up after a drawer and results in issues such as this [https://forum.unity.com/threads/application-shutdown-cleanupmono-never-finishes.1118140/page-2#post-9171365]
From what I can see, the drawer is stored in Editor.propertyHandlerCache however when the Editor is released (OnDisable etc) the drawer is still not released, even if you force propertyHandlerCache to null. It appears that it is being referenced somewhere.
Tested on 2019.4, 2021.3 and 2023.3. They all have the issue.
Calling UnloadUnsedAssets and GC.Collect does not help.
All about bugs
View bugs we have successfully reproduced, and vote for the bugs you want to see fixed most urgently.
Latest issues
- ScrollView clips content when under an ancestor that has a filter set
- "Retrieving array element that was out of bounds" error thrown when attempting to remove a column from a Multi-Column List View
- Multi-Column List View horizontal scroll resets to left most position when scrolling vertically
- Floating License is lost for concurrent jobs
- Warning "Failed to insert item" is logged when Assigning Project to Organization's Project in the Project Settings
Add comment