Search Issue Tracker

Fixed

Fixed in 2021.3.36f1, 2022.3.21f1, 2023.3.0b10

Votes

0

Found in

2021.3.36f1

2022.3.21f1

2023.3.0b9

Issue ID

UUM-64413

Regression

No

Misleading log message on Enlighten

--

-

*Steps to reproduce:*

1. It's hard to reproduce, but several users mentioned it on the forum: [https://forum.unity.com/threads/setting-up-6-worker-threads-for-enlighten-crash.1296108/]

2.  After a crash, a user may see e.g. "Setting up 2 worker threads for Enlighten." as the last log message.

3. This is misleading, as this is highly unlikely to be the cause of the crash, yet this will cause users and supporters, eventually developers, to pursue this wild goose chase and eventually waste time for everybody involved and leave the user with no solution.

*Actual results:* 

After a crash, a user may see e.g. "Setting up 2 worker threads for Enlighten." as the last log message.

*Expected results:* 

No misleading log messages

*Reproducible with versions:* 

2021, 2022, 2023

*Not reproducible with versions:* 

*Can’t test with versions:* 

*Tested on (OS):* 

*Notes:*
*  

Comments (4)

  1. belgaardunity

    Mar 11, 2024 08:05

    I can assure you that I have looked into the code in question and discussed it with developers who have years of experience with this functionality and particular code path. It's true that threads are starting up. I agree that it does not seem logical to start up threads, especially during exit, if they don't need to do any work, but that is how the internal logic has been crafted. I would not call these "Enlighen threads" but rather worker threads which can potentially do Enlighten work, when relevant. It has been verified that the crashes we have seen so far with the message in the end of the log had noting to do with Enlighten.

  2. FlightFight

    Mar 08, 2024 08:33

    I agree with BCOOK99. Enlighten should be prevented from running during application shutdown.
    Hiding the log messages isn't fixing this potential problem, only hiding it.

  3. belgaardunity

    Feb 23, 2024 08:43

    The message is truthful in the sense that it is logged when the threads are starting up. The logic for when to start up these threads is part of internal logic. If these threads actually do some work, which they won't unless Enlighten is needed, other logged messages will inform us about such details. This message has previously led investigations in the wrong direction. When Enlighten is actually relevant, a stack trace and possibly other log messages will provide the relevant information.
    In short, we do not say that the message is wrong, just misleading, and that it is not adding relevant information for investigating crashes.

  4. BCook99

    Feb 22, 2024 16:41

    Can you please explain why it is logging the message if in fact it is not erroneously preparing to start Enlighten threads during exit? This is surely a sign of code being executed that should not be executed since these projects are not using realtime global illumination. What is misleading about this? It appears you are assuming it is harmless and hiding the message as the solution instead of determining why the message is being logged in the first place.

Add comment

Log in to post comment

All about bugs

View bugs we have successfully reproduced, and vote for the bugs you want to see fixed most urgently.