Search Issue Tracker

Won't Fix

Votes

41

Found in

2022.3.16f1

2023.2.4f1

2023.3.0b1

Issue ID

UUM-59652

Regression

No

Crash on TransformAccessClearCallback when undoing ModularAvatar > Setup Outfit

--

-

Reproduction steps:
1. Open the attached project "ReproProj"
2. Open the “/Assets/scene.unity” Scene
3. Right-click “test“ GameObject (shapell > test)
4. Select ModularAvatar > Setup Outfit
5. Press CTRL + Z
6. Repeat steps 3 - 5

Expected result: Editor does not crash and continues to run
Actual result: Editor crashes

Reproducible with: 2022.3.16f1, 2023.2.4f1, 2023.3.0b1
Could not test with: 2021.3.33f1 (No ModularAvatar option)

Reproducible on: Windows 10 Enterprise 21H2
Not reproducible on: No other environment tested

Note:
- Modular Avatar is a 3rd party plugin

  1. Resolution Note:

    The crash in TransformAccessClearCallback comes from TransformAccess data that was saved into Undo being changed without updating the Undo System. This happens during a call to a user function called RebuildLock called after the undo data has been finalised. When attempting to undo, none of the relevant Transforms exist any more and clearing/applying the serialised data regarding those Transforms fails.

    Any code where new objects are created but not explicitly saved into the Undo System cannot be considered fully undoable. Additionally the Undo System cannot be expected to recover gracefully when the data it was provided is incomplete or incorrect, it is simply pointing to invalid memory once something changes without it being informed.

    In this case the constructor OnewayArmatureLock creates hundreds of unsaved Transforms and then baseBonesAccessor is switched to this list, making the TransformAccessArray data that was saved to the Undo System invalid.

    The crash described can be avoided by registering all the 'baseBone' Transforms using Undo.RegisterCreatedObjectUndo(baseBone, "") to ensure that the Transforms referred to in the TransformAccessArray contained in the Undo action still exist.

    Alternatively if the _baseBonesAccessor TransformAccessArray is disposed using _baseBonesAccessor.Dispose() before being directly overwritten the memory is cleared correctly and the Undo system is updated accordingly.

Comments (5)

  1. anastaciajoaquin19

    Feb 21, 2024 10:51

    I was once lured into a crypto currency investment platform that I came across on Instagram. I lost about $508,000 to this evil scheme after I invested and accumulated profits, I was denied withdrawals on the specified date. I wrote to the customer support but I was given no feedback, I knew I had been scammed and I started to search for a way to recover my crypto.. I considered myself fortunate that I stumbled upon a post on the internet web about a Recovery Expert Jeanson James Ancheta wizard. I would highly recommend Jeanson James Ancheta wizard agent to anyone who wants to recover their lost funds from any scam. He is the best in the business and will do anything possible to help you get your money back. I never thought it would be possible to get back crypto once it is sent but I'm super happy and grateful for the services of Jeanson James Ancheta wizard. Kindly reach out to him if you need any help.(jeansonjamesanchetawizard62 (@) gmail (.) com) or WhatsApp number: +44 (7440) 105166 or +44 (7506) 216101.

  2. tradeprecinct

    Feb 20, 2024 16:02

    ARE YOU A VICTIM OF INVESTMENT OR NFT SCAM? DO YOU WANT TO INVESTIGATE A CHEATING SPOUSE? DO YOU DESIRE CREDIT REPAIR (ALL BUREAUS)? SCHEDULE A MEETING WITH AN ETHICAL HACKER ASAP TO GET STARTED.

    Let us show you the art of Ethical Hacking….!

    EMERALD HACKS is a financial regulator, PRIVATE investigation and funds recovery body. We specialize in cases as regards ETHICAL HACKING, CRYPTOCURRENCY, FAKE INVESTMENT SCHEMES and RECOVERY SCAM. We are also experts in CREDIT REPAIR, we analyze what’s impacting your score.
    All software tools needed to execute RECOVERIES from start to finish are available in stock.
    Kindly NOTE that the available tools does NOT apply to CREDIT FIX.

    Be ALERT to FALSE reviews and testimonies on the internet, the authors and perpetrators unite to form a syndicate.

    Contact our team as soon as you can via the email address below to book a mail meeting with an ethical hacker.
    emeraldhacks(.)org@gmail(.)com

    Stay Safe out there !

  3. mmahelt93

    Feb 09, 2024 13:39

    Many fake crypto trading platforms have successfully managed to con victims of their hard-earned money. A few weeks ago, I was contacted by a crypto trader on Instagram who claimed to be a manager on a trading platform, he convinced me to invest my money into crypto mining hoping to make huge profits from it, I was convinced when I saw my account balance on their platform, but when I wanted to withdraw my earnings, they kept requesting for money for tax and other unnecessary fees. I realized then that I was being catfished, I stopped all communication and went to the internet to do my research about crypto when I came across Firmwall Cyber Security Service, a well reliable crypto recovery company, I was very pleased with the reviews I saw about this crypto recovery company and I contacted them to assist me to recover my crypto, I gave them all the information and within a few hours, Firmwall Cyber Security was able to recover my crypto assets. I’m truly grateful for their service and I highly recommend them

    E-mail = Firmwallcyber@techie. com
    Whats App = + 1 937 542 0667

  4. allendave694

    Jan 05, 2024 02:42

    Highly Recommended!
    Very insightful, i will also say this here. Investment is one of the best ways to achieve financial freedom. For a beginner there are so many challenges you face. It's hard to know how to get started. Trading on the Cryptocurrency market has really been a life changer for me. I almost gave up on crypto at some point not until saw a recommendation on Elon musk successfully success story and I got a proficient trader/broker Mr Bernie Doran , he gave me all the information required to succeed in trading. I made more profit than I could ever imagine. I'm not here to converse much but to share my testimony; I have made total returns of $10,500.00 from an investment of just $1000.00 within 1 week. Thanks to Mr Bernie I'm really grateful,I have been able to make a great returns trading with his signals and strategies .I urge anyone interested in INVESTMENT to take bold step in investing in the Cryptocurrency Market, you can reach him Gmail : BERNIEDORANSIGNALS GMAIL COM bitcoin is taking over the world, tell him I referred you

  5. sethsamson75

    Jan 02, 2024 11:44

    READ CAREFULLY
    A MESSAGE FOR VICTIMS OF FRAUD/SCAM

    It's becoming a problem how people are being victimized by scam/fraud and sadly enough, it's kind of hard to find someone to trust with the recovery of the funds or whatever have been lost. I'm afraid of getting scammed again especially by clicking any link I come across in the name of investment or recovery of lost funds. Two months ago, I was duped an appreciable amount of the BTC I have. Hired a recovery expert to get my funds back, but unfortunately, I was scammed in the process again. With so much feeling of frustration, I decided to give up everything I lost. Although I reported the case to the FBI but still, no positive outcome. I was so worried and frustrated because it was all I had in my savings plus it feels so hard for me to start saving again. I told everyone I knew about the incident, hoping that help might come. Two weeks later I read about BLISS PARADOX RECOVERY in a magazine, little did I know it was a redemption I found. I decided to take the risk again by consulting them about my lost BTC. I emailed them concerning my issues, and luckily for me, I got a reply from them that same day. Honestly speaking, I never thought I could ever get a positive outcome from the lost BTC. But they got back what I lost within 8 hours. OMG, it still feels like a dream, something too good to be true. I'm so overwhelmed sharing this story because I know there's someone out here with a similar problem seeking help. You can hire BLISS PARADOX RECOVERY, a licensed hack expert for recovery of any fraud. I would like to share the contact details you can reach out to anytime you need help or someone you know who needs help.

    Contact details below:
    MAIL: BLISSPARADOXRECOVERY @ AOL.C0M
    WHATSAPP: +1 3 8 0 2 0 6 9 7 1 2
    SIGNAL NO.: + 1 7 2 7 6 1 5 9 0 3 0
    TELEGRAM: BLISSPARADOXRECOVERY

Add comment

Log in to post comment

All about bugs

View bugs we have successfully reproduced, and vote for the bugs you want to see fixed most urgently.